Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

test: split off common_tests from common #455

Merged
merged 1 commit into from
Jan 28, 2021
Merged

test: split off common_tests from common #455

merged 1 commit into from
Jan 28, 2021

Conversation

koivunej
Copy link
Collaborator

Tiny refactoring to stop testing common::tests as part of every top level test/*.rs, noticed during #454.

@koivunej koivunej requested a review from ljedrz January 28, 2021 06:58
@koivunej
Copy link
Collaborator Author

See common::tests::check_topology_* being executed as part of:

@koivunej
Copy link
Collaborator Author

koivunej commented Jan 28, 2021 •
edited
Loading

Github actions is not firing up...? Cool cool: https://www.githubstatus.com/incidents/tf9v5jjmq2lg

@koivunej
Copy link
Collaborator Author

Transient windows failure.

ljedrz
ljedrz approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@ljedrz ljedrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this makes more sense than the original setup 👌.

@koivunej
Copy link
Collaborator Author

Thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 28, 2021

Build succeeded:

@bors bors bot merged commit 23fc80b into rs-ipfs:master Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ljedrz ljedrz ljedrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koivunej @ljedrz